Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid precedence warning #113

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

wfrisch
Copy link
Contributor

@wfrisch wfrisch commented Jul 11, 2024

Perl 5.40.0 extended the scope of the precedence warning to include ternary operators.

https://perldoc.perl.org/5.40.0/perldelta

Perl 5.40.0 extended the scope of the precedence warning to include
ternary operators.

<https://perldoc.perl.org/5.40.0/perldelta>

Reported-By: Peter Sütterlin <[email protected]>
@wfrisch wfrisch force-pushed the 2024-07-avoid_precedence_warning branch from 89575a3 to 79bb691 Compare July 11, 2024 07:56
Copy link
Owner

@aspiers aspiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks so much!

@aspiers
Copy link
Owner

aspiers commented Jul 11, 2024

We should also add 5.40 to the test matrix.

@aspiers aspiers merged commit a4178b9 into aspiers:master Jul 11, 2024
5 checks passed
@aspiers
Copy link
Owner

aspiers commented Jul 17, 2024

@aspiers commented on July 12, 2024 12:02 AM:

We should also add 5.40 to the test matrix.

Done in #114.

@ryanpeach
Copy link

@aspiers I think you may have forgotten to release the fix. Your 2.4.0 tag is behind this commit, making it still incompatible with perl 5.40.0

@aspiers
Copy link
Owner

aspiers commented Aug 25, 2024

I hadn't forgotten, it just got buried beneath a bunch of other projects. Will try to get round to it soon but I'm on a work trip all next week which may either delay or expedite depending on how intense it is. Thanks for the nudge.

Copy link

@Elijhaxx Elijhaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue.

aspiers added a commit that referenced this pull request Sep 8, 2024
@aspiers
Copy link
Owner

aspiers commented Sep 8, 2024

Now released in 2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants