fix tests

aspecto-io · May 16, 2024 · 9caa4ed · 9caa4ed
1 parent 14deba9
commit 9caa4ed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/instrumentation-neo4j/src/neo4j.ts b/packages/instrumentation-neo4j/src/neo4j.ts
@@ -4,7 +4,6 @@ import {
     SEMATTRS_DB_OPERATION,
     SEMATTRS_DB_STATEMENT,
     SEMATTRS_DB_SYSTEM,
-    SemanticAttributes,
 } from '@opentelemetry/semantic-conventions';
 import { VERSION } from './version';
 import type * as neo4j from 'neo4j-driver';

diff --git a/packages/instrumentation-neo4j/test/assert.ts b/packages/instrumentation-neo4j/test/assert.ts
@@ -6,7 +6,7 @@ import {
     SEMATTRS_DB_USER,
     SEMATTRS_NET_PEER_NAME,
     SEMATTRS_NET_PEER_PORT,
-    SemanticAttributes,
+    SEMATTRS_NET_TRANSPORT,
 } from '@opentelemetry/semantic-conventions';
 import { SpanKind, SpanStatusCode } from '@opentelemetry/api';
 
@@ -18,5 +18,5 @@ export const assertSpan = (span: ReadableSpan) => {
     expect(span.attributes[SEMATTRS_DB_USER]).toEqual('neo4j');
     expect(span.attributes[SEMATTRS_NET_PEER_NAME]).toEqual('localhost');
     expect(span.attributes[SEMATTRS_NET_PEER_PORT]).toEqual(11011);
-    expect(span.attributes[SEMATTRS_NET_PEER_PORT]).toEqual('IP.TCP');
+    expect(span.attributes[SEMATTRS_NET_TRANSPORT]).toEqual('IP.TCP');
 };
diff --git a/packages/instrumentation-neo4j/test/neo4j.spec.ts b/packages/instrumentation-neo4j/test/neo4j.spec.ts
@@ -3,7 +3,7 @@ import expect from 'expect';
 import { context, ROOT_CONTEXT, SpanStatusCode, trace } from '@opentelemetry/api';
 import { Neo4jInstrumentation } from '../src';
 import { assertSpan } from './assert';
-import { SemanticAttributes, SEMATTRS_DB_OPERATION, SEMATTRS_DB_STATEMENT } from '@opentelemetry/semantic-conventions';
+import { SEMATTRS_DB_OPERATION, SEMATTRS_DB_STATEMENT } from '@opentelemetry/semantic-conventions';
 import { normalizeResponse } from './test-utils';
 import { map, mergeMap } from 'rxjs/operators';
 import { concat } from 'rxjs';
@@ -34,7 +34,7 @@ describe('neo4j instrumentation', function () {
     };
 
     before(async () => {
-        driver = neo4j.driver('bolt://localhost:11011', neo4j.auth.basic('neo4j', 'test'), {
+        driver = neo4j.driver('bolt://localhost:11011', neo4j.auth.basic('neo4j', 'your_password'), {
             disableLosslessIntegers: true,
         });