* Fixed for Linux, GCC 64bit. #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmaloney
reviewed
Feb 13, 2020
Open
added 3 commits
June 7, 2020 23:57
* Fix wrong offset location function name
asmaloney
requested changes
Jun 8, 2020
There was a problem hiding this comment.
Thank you for the fixes/clarifications.
- Why the Windows stuff in a Linux PR? Please remove Windows binaries (I am not gong to add any binaries to the repo).
- @huseyinkozan tried your changes and did not get useful results. Could you please take a look at his issue and see if you can understand why he gets different results?
|
|
Thanks @Riflio! I'm going to give @huseyinkozan some time to try it before I merge. If he gets a chance, I'd be more comfortable if someone else can get it working as well since I can't try it on Linux. |
asmaloney
approved these changes
Jun 9, 2020
I am very sorry, I thing I had tried at Debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Nice lib, thanks!
Tested on Ubuntu 19.04 wtih Qt 5.12.3.
Have a nice day =)