feat: allow transactions to be enabled on a resource-by-resource basis. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimsynz
force-pushed
the
feat/fine-grained-transaction-control
branch
from
40971dc
to
e263f43
Compare
jimsynz
force-pushed
the
feat/fine-grained-transaction-control
branch
from
9597360
to
2ed5ab9
Compare
jimsynz
force-pushed
the
feat/fine-grained-transaction-control
branch
from
2ed5ab9
to
766edf9
Compare
zachdaniel
reviewed
Oct 21, 2024
| @@ -446,6 +483,11 @@ defmodule AshSqlite.DataLayer do | |||
| def can?(_, {:sort, _}), do: true | |||
| def can?(_, _), do: false | |||
|
|
|||
| @impl true | |||
| def in_transaction?(resource) do | |||
| AshSqlite.DataLayer.Info.repo(resource, :mutate).in_transaction?() | |||
There was a problem hiding this comment.
you mentioned that this wasn't working the way you expected it to. Have you confirmed that in_transaction?/0 works with Sqlite in general?
There was a problem hiding this comment.
also don't forget to add a rollback callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress.