-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: implement a subscription notification batcher #217
Conversation
@zachdaniel, should we merge this now? I can create a PR against main this week, removing the unnecessary data we copy. |
Yep! Just need to fix conflicts |
I can do that, if you want me to. |
That would be great, thank you 🙏 you're the best 😍 |
34461dc
to
e2e2a06
Compare
@zachdaniel I rebased. However, I had to upgrade Ash because there was an error in the alias test. This also led to an igniter update. That now triggered some Igniter Dialyzer warnings. It looks like those are just deprecation warnings. So I think it should be ok to merge this? |
Yep, I'll address those, thanks! |
This is still a WIP, but by using this strategy we can allow actions to send subscription updates out-of-band.
What remains to be done:
Later improvements
We have batchers, but in the future what we may need is a dynamic amount of them, perhaps partitioned on topic, and load balanced across a cluster potentially. I think we need to start small and test the waters in production use cases with the one orchestrating batcher first, though.