fix: make sure generic actions are authorized #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasJ
commented
Nov 24, 2023
| authorize?: AshGraphql.Api.Info.authorize?(api), | ||
| tenant: Map.get(context, :tenant) | ||
| ] | ||
|
|
||
| result = | ||
| %Ash.ActionInput{api: api, resource: resource} | ||
| |> Ash.ActionInput.set_context(get_context(context)) |
There was a problem hiding this comment.
I'm a bit confused about this because it seems like context is already the context, and those values are never attached to the action.
This looks for another nested context or ash_context inside the context. This is also done in all the other resolvers, and it seems like the actor is only set in the context because of the opts. Not sure if I'm missing something there?
There was a problem hiding this comment.
I think everything is working for now. I just wanted to make sure I understood this.
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist