[osx] Fix events handling #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
martincapello
force-pushed
the
missing-wakeups2
branch
from
e0b4636
to
f7c5cfa
Compare
martincapello
force-pushed
the
missing-wakeups2
branch
from
f7c5cfa
to
9357593
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
aseprite-bot
reviewed
Jun 7, 2024
martincapello
force-pushed
the
missing-wakeups2
branch
from
8296ba4
to
7aa8fc8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89
This is the second attempt to fix the issue. This time I just used a mutex to avoid the issue and kept almost all the code in its original form. I didn't use the concurrent queue mutex to avoid polluting its API and because I'm not sure it would be enough. Hence, if at the end the concurrent queue mutex is not going to be used I believe that we should replace that queue for a regular std::deque.