Fix get_canonical/absolute/normalize_path() functions #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dacap
force-pushed
the
paths
branch
2 times, most recently
from
e965896
to
c0793a9
Compare
aseprite-bot
reviewed
Jul 3, 2024
base/fs_unix.h
Outdated
| @@ -208,11 +209,24 @@ std::string get_user_docs_folder() | |||
|
|
|||
| std::string get_canonical_path(const std::string& path) | |||
| { | |||
| std::string full = get_absolute_path(path); | |||
There was a problem hiding this comment.
warning: variable 'full' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]
Suggested change
| std::string full = get_absolute_path(path); | |
| std::string const full = get_absolute_path(path); |
| return std::string(); | ||
| } | ||
|
|
||
| std::string get_absolute_path(const std::string& path) |
There was a problem hiding this comment.
warning: function 'get_absolute_path' defined in a header file; function definitions in header files can lead to ODR violations [misc-definitions-in-headers]
std::string get_absolute_path(const std::string& path)
^Additional context
base/fs_unix.h:220: make as 'inline'
std::string get_absolute_path(const std::string& path)
^| const std::string full = get_absolute_path(path); | ||
| DWORD attr = ::GetFileAttributes(from_utf8(full).c_str()); | ||
| if (attr != INVALID_FILE_ATTRIBUTES) | ||
| return full; |
There was a problem hiding this comment.
warning: constness of 'full' prevents automatic move [performance-no-automatic-move]
return full;
^
Several refactors in this commit: - Moved is_path_separator() function and path_separator as a constexpr to the header file - Added path_separators string (for Windows, which includes \ and /) - get_canonical_path() works only when the file exists (returns an empty string in other case) - normalize_path() and get_absolute_path() work in a lexical level, handling only strings and getting the current path when needed, but without checking the existence of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several refactors in this commit:
Fix #98