remove use of _get_yaml_content #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
The asdf documentation here: |
braingram
force-pushed
the
get_yaml_content
branch
from
b81dc08 to
467fe93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes use of the
_get_yaml_contentargument passed toasdf.open. It is replaced by usingasdf.generic_io.GenericFile.reader_untilto read the file bytes until the yaml end-of-document marker.The previous code did not read the asdf-standard nor the file version from the file using the call to
asdf.openwhere_get_yaml_contentwas passed and instead opened the file a second time to read these values. The updated code does not require this second file opening and reads these versions with the same code block usingreader_until.I don't entirely trust the CI here as testing these changes requires some downstream library to use the asdf directive. I am opening this for review but will check and update this PR once I find and manually build documentation for a project that uses the updated directive.