Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gsa): prevent exception on gsamemb2d from gwa (SPEC-522) #231

Open
wants to merge 2 commits into
base: jm/dev/2.13.0
Choose a base branch
from

Conversation

dtnaughton
Copy link

Description & motivation

Member topology that has empty brackets throws an exception e.g.

image

Changes:

  • Remove empty list entries after splitting GWA topology

To-do before merge:

N/A

Screenshots:

Validation of changes:

  • Added unit test for specific case
  • Manual test sending data to Speckle

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@dtnaughton dtnaughton requested a review from jenessaman March 30, 2023 18:59
@dtnaughton dtnaughton self-assigned this Mar 30, 2023
@dtnaughton dtnaughton changed the title fix(gsa): prevent exception on gsamemb2d from gwa (SPEC-514) fix(gsa): prevent exception on gsamemb2d from gwa (SPEC-522) Mar 31, 2023
@jenessaman jenessaman changed the base branch from master to jm/dev/2.13.0 April 24, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant