Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clears gsa cache when new file is opened on connector (SPEC-517) #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtnaughton
Copy link

Description & motivation

  • If a commit is received into GSA in one instance of SpeckleGSA, and then the user opens a new file and receives a different commit, previously data from the first commit would be kept in the cache and therefore written into the new file. This can put unintended data into the model.

Changes:

  • On selecting 'New File' on SpeckleGSA connector, the gsa cache is cleared of all records.

To-do before merge:

N/A

Screenshots:

N/A

Validation of changes:

  • Manual test receiving two different commits into different GSA models created using the 'New File' SpeckleGSA feature.

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@dtnaughton dtnaughton requested a review from jenessaman March 20, 2023 14:18
@dtnaughton dtnaughton self-assigned this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant