-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporting-data-trips.csv
- stuck agents + data structure
#34
Comments
@divyasharma-arup to check on the |
If one starts wrapping entries that are >24 h one is forced to do this everywhere in order avoid distracting users. And I found out doing this everywhere in the simulation is quite a sisyphus work. So I discarded this approach. |
@syhwawa , would you be able to check what is different between the facilities file we use for Paris East and the one we use for TE? Seems this is an issue for our TE file, but we don't have the same problem of |
From paris east simulation, the trips log outputs looks more reasonable compared to the TE outputs. There is no missing value for the Regarding the
They could be the same or not and there is an example below showing the when they're different:
Paris east gelato submission command :
|
hi Yuhao, thanks for looking into this. What does primary mode mean, and how is that different from longest distance? Do you have an idea why it would be blank in the TE sim? For facilities, Kasia thinks the Paris East sim has a different synthesis pipeline that captures the facilities IDs, but that isn't the case for the TE sim. She's thinking of a way to address that in the code base. |
@divyasharma-arup From my perspective, the "main mode" is the primary or most significant mode from the agent trip, which might not necessarily be the mode covering the longest distance. "Longest distance mode" is a purely quantitative measure. For example, when an agent walks a long distance to a pt station and takes a stop bus, and the main mode is PT and the longest distance mode is walk(An example can be found in the previous message, like trip_id: 10000500_3 ) |
The Gelato trips output, named I've noticed that the main_mode column is missing in the As Kasia pointed out, the discrepancy could likely be due to differences in the synthesis pipeline. I feel the issue happens when post-simulation outputs in MATSim rather than gelato. |
There is github issue talking about the missing value in the And the missing value happend in the trips outputs since the version of matsim we used in TE simulation is not that up-to-date. |
To recap:
@KasiaKoz, for a future release, would it be possible to address the below within the trips file? |
The trips file has some issues with stuck agents. Agents are active past the 24 hour window. We should implement a way of accounting for this perhaps as Elara does by wrapping times back into a 24 hour period. This bug will effect most KPIs.
Elara wraps in such a way that a trip at
25:00:00
is reported as01:00:00
. However we handle it in Gelato, we should clearly state this in the documentation.Additionally there's a lot of empty data columns.
main_mode
is allNaN
as we havelongest_distance_mode
. All facility related columns are empty. Can we add anend_time
column. we have start and duration but its always useful to have theend_time
and cuts out the need to calculate it each time.See TE gelato outputs
The text was updated successfully, but these errors were encountered: