Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal split parameter - unexplained differences in some modes vs. Elara #32

Closed
val-ismaili opened this issue Feb 15, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@val-ismaili
Copy link

Comments apply to TE simulation

time java -Xmx120g -jar target/gelato-0.0.1-alpha-with-dependencies-eb19697.jar \
-mc /mnt/efs/simulations_refresh/10pc/workdist_5km_20230826/200/output_config.xml \
-mo /mnt/efs/simulations_refresh/10pc/workdist_5km_20230826/200 \
-o /mnt/efs/analysis/vi/gelato/baseline

As shown by the comparison of mode splits from kpi-modal-split.csv1 compared against mode splits from elara trip_logs_all_trips.csv. Most modes line up, except for bus and rail with slightly higher values in gelato vs. lower walk split.

	mode	      elara	gelato	diff
0	bike	      0.67	0.67	0.00
1	bus	      6.88	7.09	-0.21
2	car	      69.25	69.25	0.00
3	car_passenger 9.89	9.89	0.00
4	rail	      1.41	1.43	-0.02
5	subway	      0.08	0.08	0.00
6	taxi	      0.82	0.82	0.00
7	walk	      11.00	10.77	0.23

I think both Gelato and Elara are supposed to be calculating dominant mode of a trip based on longest distance so unsure why we're getting these slight differences across bus, rail and walk.

@val-ismaili val-ismaili added the bug Something isn't working label Feb 15, 2024
@divyasharma-arup
Copy link
Contributor

@syhwawa, this issue might be related to issue 34

@syhwawa
Copy link

syhwawa commented Mar 4, 2024

The kpi-modal-split.csv outputs are created based on the analysis tabular dataoutput_trips.csv.

The method for extracting trip information in matsim can indeed be differentiated based on whether the source is the output events file or the output plans file. Elara illustrates a method for parsing the output_plans.xml file. In contrast, matsim's built-in functionality for generating output_trips.csv typically involves analyzing the output_events.xml file.

The discrepancy between the longest distance mode as defined by elara (bus) and the matsim output (rail) arise from differences in how distances are calculated or aggregated. I have checked the specific agent in the output plans and event files.

  • Elara trip is summing distances for all legs(code) and considering the mode with the highest sum as the longest distance mode. So I believe the mode is defined based on total cumulative distance across all legs
  • The matsim trip, derived from events, reflect the actual distances travelled by each mode in a single trip in one leg.

I think both methods could be "correct" depending on the analytical perspective.

@divyasharma-arup
Copy link
Contributor

I'll be closing this issue as the differences are addressed in issue 57 and the fact that gelato is using the trips file whereas Elara uses plans. We'll need to understand the usefulness of generating trips data from the plans file at a future stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants