Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#702] Remove ControllerManagerConfig #703

Merged

Conversation

brusdev
Copy link
Contributor

@brusdev brusdev commented Oct 6, 2023

The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. More info Moreover, it has undergone breaking changes and is no longer functioning as intended. As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue here.

Please, be aware that it will force Kubebuilder remove this option soon in future release.

@brusdev brusdev force-pushed the remove_controller_manager_config branch from 8b21a7f to 48ef163 Compare October 6, 2023 07:44
Copy link
Contributor

@gtully gtully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. I found my self looking for how to configure QPS for the api client rate limit and came across this and found it to be of no use :-) and now find it is deprecated - good news.

@brusdev
Copy link
Contributor Author

brusdev commented Oct 6, 2023

@gtully an alternative to ComponentConfig could be the env ARGS. This alternative works with OLM deplyments too, see https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md

I used that mechanism in #701.

@gaohoward gaohoward removed their assignment Oct 9, 2023
@gaohoward gaohoward merged commit 4a83282 into artemiscloud:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants