Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1044] Update docker image base version latest minimal image #1045

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

kevinfrommelt
Copy link
Contributor

@kevinfrommelt kevinfrommelt commented Oct 29, 2024

Update docker image base version to latest minimal image (ubi8-minimal:8.10-1086)

@kevinfrommelt
Copy link
Contributor Author

@kevinfrommelt kevinfrommelt changed the title [#1044] Update docker image base version to 8.10-1088 [#1044] Update docker image base version latest minimal image Oct 29, 2024
Copy link
Contributor

@brusdev brusdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ubi8-minimal should reduce the size of the container image and the surface for security issues.

Dockerfile Show resolved Hide resolved
@brusdev
Copy link
Contributor

brusdev commented Oct 30, 2024

@kevinfrommelt your commit to update the base image to registry.access.redhat.com/ubi8:8.10-1088 is ready to be merged
c2358c5

Updating the base image to ubi8-minimal is a bigger change and it requires more checks. I'll do those checks the next week.

In the meantime, if it is urgent you could create another PR with only the commit to update the base image to registry.access.redhat.com/ubi8:8.10-1088 so I can trigger another release after merging it.

@kevinfrommelt
Copy link
Contributor Author

@brusdev Makes sense, I can wait.

Our security scanner flagged several python packages (ex. setuptools, urllib, etc) with CVEs in the ubi8 image and many of those are still present in the latest ubi8.

@brusdev
Copy link
Contributor

brusdev commented Nov 11, 2024

@kevinfrommelt your change LGTM, can you squash your commits into one commit?

@kevinfrommelt
Copy link
Contributor Author

@brusdev Yep. All set.

@brusdev brusdev merged commit 753728d into artemiscloud:main Nov 11, 2024
2 checks passed
@kevinfrommelt kevinfrommelt deleted the update-base-image branch November 11, 2024 15:50
@brusdev
Copy link
Contributor

brusdev commented Nov 11, 2024

@kevinfrommelt thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants