refactor(eslint-plugin): address issues

artalar · Sep 12, 2024 · f740536 · f740536
1 parent d49ece0
commit f740536
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 33 deletions.
diff --git a/packages/eslint-plugin/README.md b/packages/eslint-plugin/README.md
@@ -60,7 +60,7 @@ Here is an example of React + TypeScript + Prettier config with Reatom.
     "prettier/prettier": "error"
   },
   "settings": {
-    "atomSuffix": "Atom"
+    "atomPostfix": "Atom"
   }
 }
 ```
@@ -93,7 +93,7 @@ When creating units within `reatom*`-named factory functions, you can also speci
 
 ```ts
 const reatomFood = (config: { name: string; calories: number; fat: number; carbs: number; protein: number }) => {
-  const { name } = config.name
+  const { name } = config
   const calories = atom(config.calories, `Food.calories`)
   const fat = atom(config.fat, `Food.fat`)
   const carbs = atom(config.carbs, `Food.carbs`)
@@ -106,7 +106,7 @@ If a factory function defines a parameter or a variable named `name`, names of u
 
 ```ts
 const reatomFood = (config: { name: string; calories: number; fat: number; carbs: number; protein: number }) => {
-  const { name } = config.name
+  const { name } = config
   const calories = atom(config.calories, `${name}.calories`)
   const fat = atom(config.fat, `${name}.fat`)
   const carbs = atom(config.carbs, `${name}.carbs`)

diff --git a/packages/eslint-plugin/src/rules/unit-naming-rule.test.ts b/packages/eslint-plugin/src/rules/unit-naming-rule.test.ts
@@ -88,5 +88,10 @@ tester.run('unit-naming-rule', unitNamingRule, {
       errors: [{ message: /domain must be derived from/ }],
       output: `function reatomSome({name}) { const field = atom(0, \`\${name}.field\`); }`,
     },
+    {
+      code: `function reatomSome(config) { const {name} = config; const field = atom(0, 'Some.field'); }`,
+      errors: [{ message: /domain must be derived from/ }],
+      output: `function reatomSome(config) { const {name} = config; const field = atom(0, \`\${name}.field\`); }`,
+    },
   ],
 })
diff --git a/packages/eslint-plugin/src/rules/unit-naming-rule.ts b/packages/eslint-plugin/src/rules/unit-naming-rule.ts
@@ -75,7 +75,7 @@ export const unitNamingRule: Rule.RuleModule = {
           domainScopes.push({ is: 'static', name: node.id.name.replace('reatom', '') })
         } else domainScopes.push(null)
       },
-      [`:function:exit`](node: estree.Function) {
+      [`:function:exit`]() {
         domainScopes.pop()
       },
       [`CallExpression[callee.name=${reatomFactoryPattern}]`](node: estree.CallExpression) {

diff --git a/packages/eslint-plugin/src/shared.ts b/packages/eslint-plugin/src/shared.ts
@@ -3,35 +3,6 @@ import type * as estree from 'estree'
 export const reatomFactoryList = ['atom', 'action', 'reaction'] as const
 export const reatomFactoryPattern = new RegExp(`^(reatom\\w+|${reatomFactoryList.join('|')})$`)
 
-// export const createImportMap = (packagePrefix: string) => {
-//   const imported = new Map<string, string>()
-//   const local = new Map<string, string>()
-
-//   const onImportNode = (node: estree.ImportDeclaration) => {
-//     const source = node.source.value
-//     if (typeof source !== 'string' || !source.startsWith(packagePrefix)) {
-//       return
-//     }
-
-//     for (const spec of node.specifiers) {
-//       if (spec.type === 'ImportSpecifier') {
-//         onImportSpec(spec)
-//       }
-//     }
-//   }
-
-//   const onImportSpec = (spec: estree.ImportSpecifier) => {
-//     imported.set(spec.imported.name, spec.local.name)
-//     local.set(spec.local.name, spec.imported.name)
-//   }
-
-//   return {
-//     onImportNode,
-//     imported: imported as ReadonlyMap<string, string>,
-//     local: local as ReadonlyMap<string, string>,
-//   }
-// }
-
 export const patternNames = (pattern: estree.Pattern): estree.Identifier[] => {
   if (pattern.type === 'AssignmentPattern') {
     return patternNames(pattern.left)