fix(testing): prevent first computed reading of mocked atom #995

artalar · Dec 30, 2024 · 5231d20 · 5231d20
1 parent a81e9a3
commit 5231d20
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/packages/testing/src/index.test.ts b/packages/testing/src/index.test.ts
@@ -62,4 +62,16 @@ test('mockAction', () => {
   ;`👍` //?
 })
 
+test('mock computed atom', () => {
+  const testAtom = atom<string>(() => {
+    throw new Error('unreachable')
+  }, 'testAtom')
+
+  const ctx = createTestCtx()
+
+  ctx.mock(testAtom, 'mocked')
+
+  assert.is(ctx.get(testAtom), 'mocked')
+})
+
 test.run()
diff --git a/packages/testing/src/index.ts b/packages/testing/src/index.ts
@@ -14,9 +14,7 @@ import {
 } from '@reatom/core'
 import { createMemStorage } from '@reatom/persist'
 
-export function mockFn<I extends any[], O>(
-  fn: (...input: I) => O = (...i: any) => void 0 as any,
-) {
+export function mockFn<I extends any[], O>(fn: (...input: I) => O = (...i: any) => void 0 as any) {
   const _fn = Object.assign(
     function (...i: I) {
       try {
@@ -60,10 +58,7 @@ export const getDuration = async (cb: () => void) => {
 export interface TestCtx extends Ctx {
   mock<T>(anAtom: Atom<T>, fallback: T): Unsubscribe
 
-  mockAction<I extends any[], O>(
-    anAction: Action<I, O>,
-    cb: Fn<[Ctx, ...I], O>,
-  ): Unsubscribe
+  mockAction<I extends any[], O>(anAction: Action<I, O>, cb: Fn<[Ctx, ...I], O>): Unsubscribe
 
   subscribeTrack<T, F extends Fn<[T]>>(
     anAtom: Atom<T>,
@@ -134,27 +129,22 @@ export const createTestCtx = (options?: CtxOptions): TestCtx => {
     },
     mock<T>(anAtom: Atom<T>, fallback: T) {
       const proto = anAtom.__reatom
-      let read: Fn
+      const { computer } = proto
+      proto.computer = null
 
       get((_read, actualize) => {
-        read = _read
         actualize!(ctx, proto, (patchCtx: Ctx, patch: AtomCache) => {
           patch.state = fallback
-          // disable computer
-          patch.pubs = [ctx.cause]
         })
         mocks.set(proto, fallback)
       })
 
       return () => {
-        read(proto).pubs = []
+        proto.computer = computer
         mocks.delete(proto)
       }
     },
-    mockAction<I extends any[], O>(
-      anAction: Action<I, O>,
-      cb: Fn<[Ctx, ...I], O>,
-    ) {
+    mockAction<I extends any[], O>(anAction: Action<I, O>, cb: Fn<[Ctx, ...I], O>) {
       const proto = anAction.__reatom
 
       throwReatomError(!proto.isAction, 'action expected')
@@ -167,5 +157,4 @@ export const createTestCtx = (options?: CtxOptions): TestCtx => {
 }
 
 /** @deprecated use `createMemStorage` fromm `@reatom/persist` instead */
-export const createMockStorage = (snapshot?: Rec) =>
-  createMemStorage({ name: 'test', snapshot })
+export const createMockStorage = (snapshot?: Rec) => createMemStorage({ name: 'test', snapshot })