-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow the Twill upgrade guide #622
Conversation
fb83d84
to
837d474
Compare
7471f87
to
858741c
Compare
For these commits, I ran sections of the Twill upgrade script separately, because running them all at once was throwing memory errors: For these commits, I followed Twill's lead and created a custom upgrade script of our own to make more necessary type updates: In this commit I update types in a trait that a tool like rector can't catch: In this commit, I make the required updates to I leave off before my vacation with a commit that is still a work in progress attempting to make API models implement the |
f8e87d0
to
988f1c2
Compare
988f1c2
to
af0ab6b
Compare
3503b14
to
ad3c14a
Compare
af0ab6b
to
c9fb8f1
Compare
ad3c14a
to
f48dcf0
Compare
156d65c
to
3bb38b2
Compare
f48dcf0
to
f01b04f
Compare
7be994b
to
01cfa9f
Compare
711eb44
to
58bf171
Compare
fba97e8
to
4dc4ccd
Compare
f01b04f
to
8af5c95
Compare
b60aa15
to
b8ae677
Compare
8af5c95
to
1bc9314
Compare
b8ae677
to
b920278
Compare
1bc9314
to
ad710ef
Compare
b920278
to
08b1c3e
Compare
ad710ef
to
73d5369
Compare
73d5369
to
6cea83e
Compare
08b1c3e
to
9594292
Compare
Quality Gate passedIssues Measures |
[X] Run the upgrade
I broke their upgrade script into four parts and ran them individually
Other changes:
[X] Changes in admin app url/path
We explicitly configure the admin subdomain, no action needed
[X] WYSIWYG fields defaults to Tiptap
I found no references to
quill-
orql-
prefixed css rules, no action needed[X] withVideo on media defaults to false
No instances of
withVideo
found, no action needed[X] SVG's are now no longer passing through glide
We aren't manipulating SVGs, no action needed
[X] Media library
We specify the S3 bucket credentials explicitly in the
.env
, no action needed[X] Block editor render children
All instances updated
[X] scopeForBucket replaced with getForBucket in featured
No instances of
scopeForBucket
found, no action needed[X] Crops
Added to the list of remediations WEB-2962
[X] twillIncrementsMethod and twillIntegerMethod are removed
No instances of either function found, no action needed
[X] Many methods now have typings to them
I believe we've uncovered the majority of areas we need to make typing updates, but I have a sneaking suspicion we'll still occasionally run into type warnings/errors