Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the Twill upgrade guide #622

Merged
merged 47 commits into from
Jan 17, 2025
Merged

Conversation

zachgarwood
Copy link
Member

@zachgarwood zachgarwood commented Nov 21, 2024

[X] Run the upgrade
I broke their upgrade script into four parts and ran them individually

Other changes:
[X] Changes in admin app url/path
We explicitly configure the admin subdomain, no action needed
[X] WYSIWYG fields defaults to Tiptap
I found no references to quill- or ql- prefixed css rules, no action needed
[X] withVideo on media defaults to false
No instances of withVideo found, no action needed
[X] SVG's are now no longer passing through glide
We aren't manipulating SVGs, no action needed
[X] Media library
We specify the S3 bucket credentials explicitly in the .env, no action needed
[X] Block editor render children
All instances updated
[X] scopeForBucket replaced with getForBucket in featured
No instances of scopeForBucket found, no action needed
[X] Crops
Added to the list of remediations WEB-2962
[X] twillIncrementsMethod and twillIntegerMethod are removed
No instances of either function found, no action needed
[X] Many methods now have typings to them
I believe we've uncovered the majority of areas we need to make typing updates, but I have a sneaking suspicion we'll still occasionally run into type warnings/errors

@zachgarwood zachgarwood self-assigned this Nov 21, 2024
@zachgarwood zachgarwood changed the base branch from develop to feature/twill-upgrade November 21, 2024 20:22
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch 2 times, most recently from fb83d84 to 837d474 Compare November 22, 2024 20:10
@zachgarwood zachgarwood force-pushed the feature/twill-guide branch 2 times, most recently from 7471f87 to 858741c Compare November 22, 2024 20:15
@zachgarwood
Copy link
Member Author

For these commits, I ran sections of the Twill upgrade script separately, because running them all at once was throwing memory errors:
562e2f5
6126aab
d95fd41
9a0dbbc

For these commits, I followed Twill's lead and created a custom upgrade script of our own to make more necessary type updates:
f835736
858741c

In this commit I update types in a trait that a tool like rector can't catch:
6d7929d

In this commit, I make the required updates to renderBlocks():
1382838

I leave off before my vacation with a commit that is still a work in progress attempting to make API models implement the TwillModelContract:
f8e87d0

@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from 3503b14 to ad3c14a Compare December 4, 2024 17:08
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from ad3c14a to f48dcf0 Compare December 4, 2024 20:11
@zachgarwood zachgarwood force-pushed the feature/twill-guide branch 2 times, most recently from 156d65c to 3bb38b2 Compare December 6, 2024 22:09
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from f48dcf0 to f01b04f Compare December 9, 2024 17:09
@nikhiltri nikhiltri force-pushed the feature/twill-guide branch from 7be994b to 01cfa9f Compare December 9, 2024 18:37
@zachgarwood zachgarwood marked this pull request as ready for review December 10, 2024 18:26
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from f01b04f to 8af5c95 Compare December 12, 2024 16:16
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from 8af5c95 to 1bc9314 Compare December 17, 2024 17:41
@nikhiltri nikhiltri force-pushed the feature/twill-upgrade branch from 1bc9314 to ad710ef Compare January 13, 2025 18:41
@nikhiltri nikhiltri force-pushed the feature/twill-guide branch from b920278 to 08b1c3e Compare January 13, 2025 18:49
@zachgarwood zachgarwood force-pushed the feature/twill-upgrade branch from ad710ef to 73d5369 Compare January 16, 2025 21:30
@nikhiltri nikhiltri force-pushed the feature/twill-upgrade branch from 73d5369 to 6cea83e Compare January 17, 2025 15:53
nikhiltri and others added 26 commits January 17, 2025 09:54
@nikhiltri nikhiltri force-pushed the feature/twill-guide branch from 08b1c3e to 9594292 Compare January 17, 2025 15:54
@nikhiltri nikhiltri merged commit 5e13874 into feature/twill-upgrade Jan 17, 2025
2 checks passed
@nikhiltri nikhiltri deleted the feature/twill-guide branch January 17, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants