Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a sanity check that calls to_matrices before inlining #42

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Remove a sanity check that calls to_matrices before inlining #42

merged 1 commit into from
Nov 12, 2020

Conversation

weikengchen
Copy link
Member

#41

@weikengchen weikengchen requested a review from Pratyush November 12, 2020 06:07
@Pratyush
Copy link
Member

Hmm because outlining changes the dimensions of the matrices, we should probably be making the matrices square after outlining, no?

@weikengchen
Copy link
Member Author

I would suggest handling that problem in the constraints PR (which currently just comment it out) since the master branch is currently doing inlining. (And I think it needs an emergent fix.)

@Pratyush Pratyush merged commit 6065113 into master Nov 12, 2020
@Pratyush Pratyush deleted the fix-indexer-to-matrices branch November 12, 2020 06:48
@Pratyush Pratyush mentioned this pull request Nov 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Awaiting requested review from Pratyush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weikengchen @Pratyush