arithmetic: add unit tests #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
z-tech,
Pratyush and
mmagician
and removed request for
a team
tcoratger
commented
Nov 15, 2024
| @@ -41,7 +41,7 @@ pub fn adc_for_add_with_carry(a: &mut u64, b: u64, carry: u8) -> u8 { | |||
| /// Calculate a + b + carry, returning the sum | |||
| #[inline(always)] | |||
| #[doc(hidden)] | |||
| pub fn adc_no_carry(a: u64, b: u64, carry: &mut u64) -> u64 { | |||
| pub fn adc_no_carry(a: u64, b: u64, carry: &u64) -> u64 { | |||
There was a problem hiding this comment.
I think that we don't need the carry to be a mutable ref here
There was a problem hiding this comment.
good catch, seems like this was a copy-paste error
Pratyush
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer