ff: refactor cubic extension (#881)

arkworks-rs · Nov 19, 2024 · 93fc31e · 93fc31e
1 parent 7ab833a
commit 93fc31e
Showing 1 changed file with 8 additions and 17 deletions.
diff --git a/ff/src/fields/models/cubic_extension.rs b/ff/src/fields/models/cubic_extension.rs
@@ -632,7 +632,7 @@ impl<P: CubicExtConfig> CanonicalDeserializeWithFlags for CubicExtField<P> {
         let c0 = CanonicalDeserialize::deserialize_compressed(&mut reader)?;
         let c1 = CanonicalDeserialize::deserialize_compressed(&mut reader)?;
         let (c2, flags) = CanonicalDeserializeWithFlags::deserialize_with_flags(&mut reader)?;
-        Ok((CubicExtField::new(c0, c1, c2), flags))
+        Ok((Self::new(c0, c1, c2), flags))
     }
 }
 
@@ -651,13 +651,10 @@ impl<P: CubicExtConfig> CanonicalDeserialize for CubicExtField<P> {
         compress: Compress,
         validate: Validate,
     ) -> Result<Self, SerializationError> {
-        let c0: P::BaseField =
-            CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
-        let c1: P::BaseField =
-            CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
-        let c2: P::BaseField =
-            CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
-        Ok(CubicExtField::new(c0, c1, c2))
+        let c0 = CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
+        let c1 = CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
+        let c2 = CanonicalDeserialize::deserialize_with_mode(&mut reader, compress, validate)?;
+        Ok(Self::new(c0, c1, c2))
     }
 }
 
@@ -666,15 +663,9 @@ where
     P::BaseField: ToConstraintField<P::BasePrimeField>,
 {
     fn to_field_elements(&self) -> Option<Vec<P::BasePrimeField>> {
-        let mut res = Vec::new();
-        let mut c0_elems = self.c0.to_field_elements()?;
-        let mut c1_elems = self.c1.to_field_elements()?;
-        let mut c2_elems = self.c2.to_field_elements()?;
-
-        res.append(&mut c0_elems);
-        res.append(&mut c1_elems);
-        res.append(&mut c2_elems);
-
+        let mut res = self.c0.to_field_elements()?;
+        res.extend(self.c1.to_field_elements()?);
+        res.extend(self.c2.to_field_elements()?);
         Some(res)
     }
 }