Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarify that ASP signs funding PSBT #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: clarify that ASP signs funding PSBT #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/learn/concepts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ import TabItem from '@theme/TabItem';
- ASP adds the added output in the [Funding transaction](#funding-transaction) shared by Alice.
- ASP spends from the `Alice + ASP` cooperative path.
- ASP adds the output with the script `(Alice + ASP) or (Alice after 24h)`. This output is the [VTXO](#vtxo) of Alice.
- ASP signs the PSBT and sends it to Alice.
- ASP signs the Funding PSBT and sends it to Alice.
Copy link
Member

@tiero tiero Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this is not correct, first is the Redeem transaction to be signed. After this, Alice can sign his original Funding.

  1. Change this Redeem PSBT (left suggestion)
  2. In the next sentence we can be more clear saying "It's now safe for Alice to sign and broadcast his funding.."
Suggested change
- ASP signs the Funding PSBT and sends it to Alice.
- ASP signs the Redeem PSBT, sends it to Alice who counter-signs.

- Is now safe for Alice to broadcast his funding transaction because now she can leave anytime with Redeem transaction spending from `Alice in 24h` path.

| Inputs | Outputs |
Expand Down Expand Up @@ -156,4 +156,4 @@ import TabItem from '@theme/TabItem';
| Inputs | Outputs |
| -------- | ----------------- |
| ASP UTXO | Shared output |
| | Connectors output |
| | Connectors output |