Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use int[] instead of string to allow dots with double digit indexes (stringToPattern becomes intArrayToPattern) #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

buffermet
Copy link

fixes #31

…xes (stringToPattern becomes intArrayToPattern)
@maxkeppeler
Copy link

Did this get implemented yet? It's really needed and should be fixed!

@buffermet
Copy link
Author

@MaximilianKeppeler this is indeed a severe bug that should be fixed ASAP. It seems that @aritraroy has not been maintaining his GitHub repositories for a while, so in the meantime you can use my repo https://github.com/buffermet/PatternLockView in which I have applied a patch for most issues.

@buffermet
Copy link
Author

It looks like @aritraroy has been recently active on GitHub but he has not been bothered to address any issues...

Use my repo instead: https://github.com/buffermet/PatternLockView

@maxkeppeler
Copy link

Thanks @buffermet , I fixed this problem in a few seconds yesterday though. I just didn't expect such a fundamental thing would not work. I might use your fork though, since it contains more and various fixes!. :) @aritraroy Would be cool if you write into the README, that you don't maintaine it anymore, for the new visitors. Also perhaps add some forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: unable to set pattern when dot index exceeds 9
2 participants