Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on b_column_size to show core temps #798

Closed
wants to merge 1 commit into from

Conversation

RipleyTom
Copy link

b_column_size calculation always takes into account 6 columns to show temperature:

        #ifdef GPU_SUPPORT
            b_columns = max(1, (int)ceil((double)(Shared::coreCount + 1) / (height - gpus_extra_height - 5)));
        #else
            b_columns = max(1, (int)ceil((double)(Shared::coreCount + 1) / (height - 5)));
        #endif
            if (b_columns * (21 + 12 * show_temp) < width - (width / 3)) {
                b_column_size = 2;
                b_width = (21 + 12 * show_temp) * b_columns - (b_columns - 1);
            }
            else if (b_columns * (15 + 6 * show_temp) < width - (width / 3)) {
                b_column_size = 1;
                b_width = (15 + 6 * show_temp) * b_columns - (b_columns - 1);
            }
            else if (b_columns * (8 + 6 * show_temp) < width - (width / 3)) {
                b_column_size = 0;
            }
            else {
                b_columns = (width - width / 3) / (8 + 6 * show_temp);
                b_column_size = 0;
            }

So I assume showing core temps should not depend on b_column_size.
This fixes core temperatures not showing for me.

@aristocratos
Copy link
Owner

@RipleyTom
It was a check further down that was the issue, see commit 3f384c0

The check you are referencing is not wrong, since it only disabled the creation of the temp graphs if the size is too small. The issue with the missing temp number was because the drawing of the text was in the same if statement as the graphs, they are now separated.

@RipleyTom RipleyTom closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants