Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetBSD Support. #703

Merged
merged 16 commits into from
Aug 4, 2024
Merged

Conversation

fraggerfox
Copy link
Contributor

@fraggerfox fraggerfox commented Jan 6, 2024

Add support for NetBSD. (Addresses #301)

A lot of the work has been taken from the PR to bring up OpenBSD support. #607

image

NOTE: Battery and Thermal stats are shown based on some guess work.

Thanks to @0-wiz-0 for helping test and debug the NetBSD specific changes.

NOTE: Once this is merged, a follow up PR will update the README.md with additional information for building / installing in NetBSD. The PR has the updated README.md.

Pending changes

  • Verify the memory stats shown is correct.
  • Fixed the swap memory calculation.
  • Add support for querying battery stats.
  • Add support for querying thermal stats.
  • Fix utf issues when starting up in NetBSD.
  • Add CI for nebtsd based builds.

@fraggerfox fraggerfox force-pushed the add-netbsd-support branch 2 times, most recently from 2ac8ac0 to fd0b7c1 Compare January 9, 2024 12:42
@fraggerfox fraggerfox force-pushed the add-netbsd-support branch 10 times, most recently from 2e06ae7 to 637aeb3 Compare February 24, 2024 10:13
@fraggerfox fraggerfox force-pushed the add-netbsd-support branch 8 times, most recently from 4a583a4 to f88d8f6 Compare March 3, 2024 09:32
@fraggerfox fraggerfox marked this pull request as ready for review March 3, 2024 09:37
@imwints
Copy link
Contributor

imwints commented Mar 3, 2024

You should also update all other CI files to exclude the new netbsd path.

src/netbsd/btop_collect.cpp Outdated Show resolved Hide resolved
src/netbsd/btop_collect.cpp Outdated Show resolved Hide resolved
@fraggerfox
Copy link
Contributor Author

You should also update all other CI files to exclude the new netbsd path.

Good point, let me do that update.

@fraggerfox
Copy link
Contributor Author

You should also update all other CI files to exclude the new netbsd path.

Good point, let me do that update.

Should be done in the latest commit.

@aristocratos
Copy link
Owner

@fraggerfox

Is this PR finished?
If so, do you wanna note down in this thread if there are any specific dependencies or instructions for compiling on NetBSD.

Just to save me the trouble later when doing testing.

Any links to VM images of current NetBSD release would also be helpful.

@aristocratos
Copy link
Owner

NOTE: Once this is merged, a follow up PR will update the README.md with additional information for building / installing in NetBSD.

I would recommend you include the README.md changes in this PR also if you don't mind, it would speed things along when I have time to look through everything and do testing.
Since I will likely be pushing a new release once this is merged.

@fraggerfox
Copy link
Contributor Author

@fraggerfox

Is this PR finished? If so, do you wanna note down in this thread if there are any specific dependencies or instructions for compiling on NetBSD.

Just to save me the trouble later when doing testing.

Any links to VM images of current NetBSD release would also be helpful.

I have added an updated README.md with the instructions for NetBSD.

You can find the VM image which I have used from here

but if you want to load it up in a Virtualbox like environment, the ISO from NetBSD should help out

@fraggerfox
Copy link
Contributor Author

@aristocratos Do let me know if any additional information / changes are needed from my end to help merge this PR? It will also help us to finish off the package for this in NetBSD. Thank you!

Copy link
Owner

@aristocratos aristocratos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working great :)

Big thanks for contributing!

@aristocratos aristocratos merged commit 3ea0cb6 into aristocratos:main Aug 4, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants