-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Yomitan v3 schema (focusing on Jitendex) #389
base: main
Are you sure you want to change the base?
feat: Support Yomitan v3 schema (focusing on Jitendex) #389
Conversation
…BetterSorting feature: sort by longest exact match in immersion kit & massif
… Yomitan's original implementation.
I did a lot of hacky things in 05dd4a1, but the text sent to AnkiDroid should be fairly readable for simple and complex HTML structures. I've not used the Card Exporter feature before though, so let me know if anything breaks. |
Hi, firstly. Thank you for your pull request. I think I've been vague for a long time but I'm working on a v3 rewrite of the app which more than addresses the change you want to make, and there have since been some changes in my life that have gotten in the way of that. I will take a look at your pull request soon, but I want to say -- I appreciate it and I'm happy you're interested to contribute. |
Hi, thanks for the update on what you're working on. A complete rewrite must be quite a momentous effort though, looking at the code @_@. Sorry to hear life is getting in the way, I can relate. Take your time with the PR. It was mostly for myself as a learning experience |
Hey all, would it be possible to take another look at this pr? Jitendex in my experience is by far the best free dictionary, and even often better than paid ones. |
This PR tries to support the latest V3 dict schema provided by Yomitan, with a focus on rendering Jitendex's dictionary entries nicely (see pics).
This is my first time working with mobile dev and Dart/Flutter, so I appreciate your patience.
Changes:
structured_content.dart
to more closely follow Yomitan's implementation (didn't have any clue on how to properly process nested children in tags other than divs that are in a list)Known issues:
listStyleType
(aka bulletpoints) do not display, resulting in weird bugs.flutter_html
does not support these yetEDIT: Forgot screenshots