Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: sort by longest exact match in immersion kit & massif #370

Merged

Conversation

m-edlund
Copy link
Contributor

@m-edlund m-edlund commented Mar 3, 2024

Makes a slight improvement to sorting in immersion kit. For words where there are a lot of unfitting results returned by immersion kit, this should float the best ones to the top.

ImmersionKit Example:

Compound verbs such as 聞き入る

Before After
image image

Rare kanji versions of common words such as 成る

Before After
image image

Massif Example:

Compound verbs such as 聞き入る

Before After
image image

Rare kanji versions of common words such as 聴き入る

Before After
image image

@m-edlund m-edlund changed the title feature: sort by longest exact match in immersion kit feature: sort by longest exact match in immersion kit & massif Mar 3, 2024
@arianneorpilla arianneorpilla merged commit 933b368 into arianneorpilla:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants