[WIP] Setup rollup #75
Conversation
|
This looks ok to me—I'd like to replace the custom umd export at the end with an I think we should add a make target as you say. I'm open to migrating to npm scripts in the future, but would like to do that all at once when we do. Unfortunately I believe the make target may have to be phony because I've had issues with non-phony targets and timestamps not being updated by some git operations. I'm probably missing something here, but thankfully phony targets aren't very expensive for a small project like this. |
Adds some integration for rollup/the rollup changes with some other parts of the build system: * `make` targets * fixes typescript config * uses es6 module exports to switch to fully using rollup's umd * integrates rollup with npm prepublish so I can't forget to build
|
Added some integrations with make & npm prepublish, and switched to es6 exports so we can use all of rollup's umd instead of my homegrown one; thanks! (37a72f1) I have some ideas for where this could go that might be useful if you're interested! Or if you have ideas, I'm interested in hearing or seeing them! That said, I want to make sure that with any infrastructure changes we:
If we could eventually support es6 named exports for tree shaking like you suggested in #55, I think that would be really neat and match the above criteria. I'm not totally sure how to ensure that typescript and flow play well with both versions, but it's probably doable. You probably have other ideas as well :). |
|
Awesome 👍 |
It started at #14 a long time ago.
I added a really basic setup of rollup. All that is done right now is just replacing hand-written IIFE with the one that rollup adds. Exports are still manual. Should I continue at this point or something doesn't look right already? I probably should add non-phony make target for
simple-markdown.js. Is it correct?