Rz logging dedup2 #454
Rz logging dedup2 #454
Conversation
|
Test using |
| @@ -475,7 +483,7 @@ def main(): | |||
| # Pass DEM-filename, loaded DEM array, and lat/lon arrays | |||
| LOGGER.info('Download/cropping DEM') | |||
| demfile, demfile_expanded, lat, lon = \ | |||
| ARIAtools.util.dem.prep_dem(**dem_dict) | |||
| ARIAtools.util.dem.prep_dem(**dem_dict, run_log=run_log) | |||
There was a problem hiding this comment.
this line causes the ariaTSsetup.py to die with the error:
TypeError: prep_dem() got an unexpected keyword argument 'run_log'
run_log needs to be added as a variable at the top of the function or removed from here.
|
|
||
| class RunLog: | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
| """ | ||
| def __init__(self, workdir, verbose=None): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def load(self): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def update(self, atr_name, atr_value): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def __update_runtimes__(self): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def __update_configs__(self, atr_name, atr_value): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def __write_file_list__(self, files): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
|
||
| def __write_extracted_files__(self, extracted_files): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
populate or remove the docstring triple quotes
|
These are my comments IMO should phase out use of verbose and let the log level control this type of messaging to the user. The prints which are guarded by if verbose should probably be LOGGER.debug messages. Recommend to rename run_logging module to runlog (shorter, module name matches class name i.e. runlog.RunLog). use full namespace to match existing style in imports, almost always with very few exceptions -- this is why it is important to make short and explicit module and package names as per comment above. imports in run_logging should roughly follow the isort ordering (i.e. in three blocks: system, third party, our own) doc strings should be populated with something Ideally, logger messages should use lazy formatting, not f-strings or % strings. These are formatted even if the logger message is not written, whereas lazy formatted strings are only formatted if the message will be written. Changing it everywhere would be a premature optimization but one should get in the habit of using lazy formatting always going forward. recommend renaming atr to attr in atr_name, atr_value. This is more pythonic -- see getattr / setattr method names. |
Latest updates to prevent or minimize reprocessing for ariaTSsetup and ariaExtract.
Logging included.