Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): 🎨 vendor some code from k8s.io/kubernetes to remove depen… #108

Closed
wants to merge 1 commit into from
Closed

fix(deps): 🎨 vendor some code from k8s.io/kubernetes to remove depen… #108

wants to merge 1 commit into from

Conversation

ghostsquad
Copy link

…dency

part of #56

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2020

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #108 into master will increase coverage by 0.12%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   56.04%   56.16%   +0.12%     
==========================================
  Files          25       26       +1     
  Lines        2680     2699      +19     
==========================================
+ Hits         1502     1516      +14     
- Misses       1035     1038       +3     
- Partials      143      145       +2     
Impacted Files Coverage Δ
pkg/health/pod.go 73.68% <73.68%> (ø)
pkg/health/health.go 55.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d47a6...a698edf. Read the comment docs.

@ash2k
Copy link
Member

ash2k commented Jul 28, 2020

I think it's not worth it as this only solves 1% of the problem :) I think our best chance is to talk to k8s maintainers and figure out what the plans are to move this code out of the main repo. I know there is a lot of shuffling going on so maybe these bits are already scheduled to be moved somewhere? If not, this can be a data point in support of such a move.

@ghostsquad
Copy link
Author

Sounds good.

@ghostsquad ghostsquad closed this Oct 31, 2020
@ghostsquad ghostsquad deleted the fix/remove-kubernetes-dependency branch October 31, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants