add test in pkg/health/health_test.go

Signed-off-by: Arnaud Farbos <[email protected]>
argoproj · Sep 5, 2024 · 4d25c5a · 4d25c5a
1 parent e460207
commit 4d25c5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/health/health_hpa.go b/pkg/health/health_hpa.go
@@ -147,7 +147,7 @@ func checkConditions(conditions []hpaCondition, progressingStatus *HealthStatus)
 		}
 	}
 
-	if len(conditions) == len(healthyMessages) {
+	if len(healthyMessages) > 0 {
 		return &HealthStatus{Status: HealthStatusHealthy, Message: strings.Join(healthyMessages, ",")}, nil
 	}
 

diff --git a/pkg/health/health_test.go b/pkg/health/health_test.go
@@ -81,6 +81,7 @@ func TestJob(t *testing.T) {
 func TestHPA(t *testing.T) {
 	assertAppHealth(t, "./testdata/hpa-v2-healthy.yaml", HealthStatusHealthy)
 	assertAppHealth(t, "./testdata/hpa-v2-degraded.yaml", HealthStatusDegraded)
+	assertAppHealth(t, "./testdata/hpa-v2-degraded-partially.yaml", HealthStatusDegraded)
 	assertAppHealth(t, "./testdata/hpa-v2-progressing.yaml", HealthStatusProgressing)
 	assertAppHealth(t, "./testdata/hpa-v2beta2-healthy.yaml", HealthStatusHealthy)
 	assertAppHealth(t, "./testdata/hpa-v2beta1-healthy-disabled.yaml", HealthStatusHealthy)