-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): support cap on retryStrategy backoff. Fixes #13772 #13782
base: main
Are you sure you want to change the base?
Conversation
Do you know why "CI / Codegen (pull_request)" fails @chengjoey ? |
The failure in CI is because |
hi @Joibel , I made sure I ran Line 158 in cd87c50
There are some strange things when I execute this step locally. I need to manually add
Am I missing the correct prefix step |
You can verify what the CI is complaining about here, which I got to by finding the failing check in the list of checks and hitting the I don't quite follow where you need to add Please note: the |
Signed-off-by: joey <[email protected]>
905f8a1
to
90e0a8a
Compare
thanks @Joibel , it worked! |
Fixes #13772
Motivation
support cap on retryStrategy backoff
Modifications
cap
filed on retryStrategy.Backoffcap
as retry duration if duration with factor > capVerification
unit test