refactor(deps): remove moment
dep and usage
#12611
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the goals of #12059, just removing / replacing a large dep entirely.
Follow-up to #12097
Motivation
moment
has been deprecated since Sep 2020 and recommends using nativeIntl
or newer libraries that make use of nativeIntl
, such asluxon
andday.js
moment
is also a very large dependency and hence is ripe for pruning and replacement as wellshave off X kb by replacing ~15 LoC
Modifications
moment
with regularDate
functionsvalueOf()
works the same way forDate
andmoment
diff
doesn't exist, but it's a one-liner helperformat
doesn't exist, but we can also use a simple helper for thatVerification
TODO: insert screenshots of UI and
webpack-bundle-analyzer
NOTE: This is still a draft right now as to fully remove
moment
requires upstream changes inargo-ui
: argoproj/argo-ui#535