fix: The navItems are not clickable with vimium (accessibility) #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Fresco <[email protected]>
michaelfresco
changed the title
agilgur5
reviewed
May 12, 2024
| @@ -36,7 +36,7 @@ export const NavBar: React.FunctionComponent<NavBarProps> = (props: NavBarProps, | |||
| {(props.items || []).map((item) => ( | |||
| <Tooltip content={item.title} placement='right' arrow={true} key={item.path + item.title}> | |||
| <div className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })} | |||
| onClick={() => context.router.history.push(item.path)}> | |||
| onClick={() => context.router.history.push(item.path)} role="checkbox"> | |||
There was a problem hiding this comment.
- At the moment, the navItems do not show up as links, because they do not contain a typical
<a href>
why not use an actual <Link> component here? Same as #222 (comment), that would resolve #166 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a tag
role="checkbox"to the navItems. This has the benefit that keyboard users can use vimium to navigate the user interface. At the moment, the navItems do not show up as links, because they do not contain a typical<a href>Adding
role="checkbox"works around that issue, and makes them clickablePlease also see the original issue: The navItems are not clickable with vimium (accessibility) argo-workflows#12813