fix(controller): weighted experiment validation should allow delegating to trafficRouter plugins #3909
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezmax
force-pushed
the
maksimb/allow-plugins-for-weighted-experiments
branch
from
aa87e33
to
8d7e677
Compare
…ng to trafficRouter plugins Signed-off-by: Maksim Bezsaznyj <[email protected]>
bezmax
force-pushed
the
maksimb/allow-plugins-for-weighted-experiments
branch
from
8d7e677
to
0450cd4
Compare
|
Published E2E Test Results 4 files 4 suites 3h 15m 28s ⏱️ For more details on these failures, see this check. Results for commit 0450cd4. |
Published Unit Test Results2 279 tests 2 279 ✅ 2m 59s ⏱️ Results for commit 0450cd4. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3909 +/- ##
==========================================
+ Coverage 82.69% 82.70% +0.01%
==========================================
Files 163 163
Lines 22886 22886
==========================================
+ Hits 18925 18928 +3
+ Misses 3087 3085 -2
+ Partials 874 873 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though weighted experiment calls are correctly delegated to Traffic Router plugins, the validation is currently not allowing to register a TrafficRouting plugin when weighted experiments are present.
It seems that this validation was added before plugin architecture supported
additionalDestinations, so it made sense then. Ideally a plugin would have a way to announce it's capabilities, but given right now API does not have anything suitable for that - this PR provides a simple way to unblock using plugins that support weighted experiments.Checklist:
"fix(controller): Updates such and such. Fixes #1234".