Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #3868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cuishuang
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

The intention here should be to initialize a slice with a capacity of 3 rather than initializing the length of this slice.

The only demo: https://go.dev/play/p/q1BcVCmvidW

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Published E2E Test Results

  4 files    4 suites   3h 15m 42s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 06448fb.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Published Unit Test Results

2 275 tests   2 275 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 06448fb.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (6ced7fc) to head (06448fb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
- Coverage   83.87%   83.84%   -0.04%     
==========================================
  Files         163      163              
  Lines       18564    18564              
==========================================
- Hits        15571    15565       -6     
- Misses       2120     2123       +3     
- Partials      873      876       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant