-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Application controller can run out of disk space on '/dev/shm' (#19201) #19202
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
go.mod
Outdated
@@ -292,6 +292,7 @@ require ( | |||
) | |||
|
|||
replace ( | |||
github.com/argoproj/gitops-engine => github.com/jgwest/gitops-engine v0.1.3-0.20240717115355-a88f58020142 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self/reviewer: Ensure this is removed after gitops-engine PR is merged.
1192e52
to
bcc5c2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19202 +/- ##
=======================================
Coverage 55.87% 55.87%
=======================================
Files 316 316
Lines 43794 43798 +4
=======================================
+ Hits 24471 24474 +3
Misses 16775 16775
- Partials 2548 2549 +1 ☔ View full report in Codecov by Sentry. |
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
bcc5c2d
to
66222f1
Compare
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
Closes #19201
This PR allow the user to customize which path with the application controller container is used to store temporary kubernetes manifests.
See parent issue, and gitops-engine issue/PR, for details.
This PR:
ARGOCD_APPLICATION_CONTROLLER_MANIFEST_GENERATION_PATH
Deployment
/StatefulSet
updated to optionally read the value fromargocd-cmd-params-cm
controller.manifest.generation.path
inargocd-cmd-params-cm
argocd-cmd-params-cm
docsutil/git/creds.go
Checklist: