Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from maintainers as per Slack post in CNCF :) #1267

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

flaviuvadan
Copy link
Collaborator

Follow up to the post in the CNCF #hera-argo-sdk channel: https://cloud-native.slack.com/archives/C03NRMD9KPY/p1731779810181619

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (185f2e1) to head (6413814).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1267   +/-   ##
=====================================
  Coverage   86.2%   86.2%           
=====================================
  Files         60      60           
  Lines       4113    4113           
  Branches     660     660           
=====================================
  Hits        3547    3547           
  Misses       393     393           
  Partials     173     173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flaviuvadan flaviuvadan enabled auto-merge (squash) November 17, 2024 20:21
Copy link
Collaborator

@sambhav sambhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work on Hera!

@sambhav sambhav added the type:skip-changelog A change that does not require a changelog entry label Nov 17, 2024
@flaviuvadan flaviuvadan merged commit 250a09e into main Nov 17, 2024
25 checks passed
@flaviuvadan flaviuvadan deleted the fv/remove-fv branch November 17, 2024 21:23
@sambhav sambhav restored the fv/remove-fv branch November 17, 2024 21:23
@sambhav sambhav deleted the fv/remove-fv branch November 17, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:skip-changelog A change that does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants