Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with with_param #1236

Merged
merged 14 commits into from
Oct 25, 2024

Merge branch 'main' into get.param.items.bugfixes

9b471d2
Select commit
Loading
Failed to load commit list.
Merged

Fix issues with with_param #1236

Merge branch 'main' into get.param.items.bugfixes
9b471d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 21, 2024 in 1s

45.8% (-0.2%) compared to 12de907

View this Pull Request on Codecov

45.8% (-0.2%) compared to 12de907

Details

Codecov Report

Attention: Patch coverage is 11.76471% with 45 lines in your changes missing coverage. Please review.

Project coverage is 45.8%. Comparing base (12de907) to head (9b471d2).

Files with missing lines Patch % Lines
src/hera/workflows/_meta_mixins.py 8.0% 23 Missing ⚠️
src/hera/workflows/script.py 7.1% 13 Missing ⚠️
src/hera/shared/_type_util.py 16.6% 5 Missing ⚠️
src/hera/workflows/_mixins.py 25.0% 3 Missing ⚠️
src/hera/workflows/io/_io_mixins.py 50.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1236     +/-   ##
=======================================
- Coverage   45.9%   45.8%   -0.2%     
=======================================
  Files         60      60             
  Lines       4096    4110     +14     
  Branches     861     863      +2     
=======================================
+ Hits        1884    1886      +2     
- Misses      2180    2192     +12     
  Partials      32      32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov