Skip to content

Commit

Permalink
Fix not handling list of all primitive types in SignatureMixin (#1037)
Browse files Browse the repository at this point in the history
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
gabrielmbmb and pre-commit-ci[bot] authored Oct 16, 2024
1 parent c0d798a commit 55c95bd
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 10 deletions.
3 changes: 2 additions & 1 deletion examples/arena_hard.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@
import re
from typing import Any, Dict, List, Optional, Union

from typing_extensions import override

from distilabel.steps import GlobalStep, StepInput
from distilabel.steps.tasks.base import Task
from distilabel.steps.tasks.typing import ChatType
from distilabel.steps.typing import StepOutput
from typing_extensions import override


class ArenaHard(Task):
Expand Down
7 changes: 4 additions & 3 deletions examples/deepseek_prover.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,15 @@
from textwrap import dedent
from typing import Any, Dict, List, Optional, Union

from jinja2 import Template
from pydantic import PrivateAttr
from typing_extensions import override

from distilabel.llms import InferenceEndpointsLLM
from distilabel.pipeline import Pipeline
from distilabel.steps import LoadDataFromHub
from distilabel.steps.tasks.base import Task
from distilabel.steps.tasks.typing import ChatType
from jinja2 import Template
from pydantic import PrivateAttr
from typing_extensions import override

_PARSE_DEEPSEEK_PROVER_AUTOFORMAL_REGEX = r"```lean4(.*?)```"

Expand Down
3 changes: 2 additions & 1 deletion examples/structured_generation_with_instructor.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@

from typing import List

from pydantic import BaseModel, Field

from distilabel.llms import MistralLLM
from distilabel.pipeline import Pipeline
from distilabel.steps import LoadDataFromDicts
from distilabel.steps.tasks import TextGeneration
from pydantic import BaseModel, Field


class Node(BaseModel):
Expand Down
5 changes: 3 additions & 2 deletions examples/structured_generation_with_outlines.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
from enum import Enum
from pathlib import Path

from pydantic import BaseModel, StringConstraints, conint
from typing_extensions import Annotated

from distilabel.llms import LlamaCppLLM
from distilabel.pipeline import Pipeline
from distilabel.steps import LoadDataFromDicts
from distilabel.steps.tasks import TextGeneration
from pydantic import BaseModel, StringConstraints, conint
from typing_extensions import Annotated


class Weapon(str, Enum):
Expand Down
2 changes: 1 addition & 1 deletion src/distilabel/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

from rich import traceback as rich_traceback

__version__ = "1.4.0"
__version__ = "1.4.1"

rich_traceback.install(show_locals=True)
4 changes: 2 additions & 2 deletions src/distilabel/mixins/signature.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ def flatten_dump(d: Any, parent_key: str = "", sep: str = "_") -> List:
elif isinstance(v, list):
if len(v) == 0:
items.append((new_key, ""))
elif isinstance(v[0], str):
items.append((new_key, "-".join(v)))
elif isinstance(v[0], (str, float, int, bool)):
items.append((new_key, "-".join(map(str, v))))
else:
for i, x in enumerate(v):
items.extend(flatten_dump(x, f"{new_key}-{i}", sep=sep))
Expand Down

0 comments on commit 55c95bd

Please sign in to comment.