Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Argilla CallBack for haystack #2

Merged

Conversation

kursathalat
Copy link
Contributor

@kursathalat kursathalat commented Jan 4, 2024

As pointed out in argilla-io/argilla#4235 and #1, this PR creates the first version of the CallBackHandler for Argilla. This first version introduces the basic functionalities with the given to-dos. With the test file, the script can be run for testing.

@kursathalat kursathalat self-assigned this Jan 4, 2024
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good already. Could you add an example .md to showcase the usage and remove nb-test?

haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
@davidberenstein1957
Copy link
Member

@kursathalat https://docs.argilla.io/en/latest/tutorials_and_integrations/integrations/use_argilla_callback_in_langchain.html#an-llm

an overview like this would be great :)

@davidberenstein1957
Copy link
Member

@alvarobartt do you think it makes sense to align this with the chat format you discussed for distilabel and potentially align that within out langchain integration too?

environment_dev.yml Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
haystack_argilla/base.py Outdated Show resolved Hide resolved
@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jan 11, 2024

Hi @kursathalat, I've just set up the outline for the project and created an initial deployment. Would you be able to work on the following things:

  • update readme.md with a basic example we can reuse. Something of the length of out Langchain should work, however, something a bit longer like other examples at Haystack is better.
  • create a tests module with functionality tests
  • create a PR at haystack-integrations
  • Also, some basic code can be cleaned by removing comments etc.

@davidberenstein1957 davidberenstein1957 changed the base branch from develop to main January 23, 2024 15:01
@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review January 23, 2024 15:01
@davidberenstein1957 davidberenstein1957 merged commit f4ec0a2 into main Jan 23, 2024
@kursathalat kursathalat linked an issue Jan 23, 2024 that may be closed by this pull request
sdiazlor pushed a commit that referenced this pull request Feb 20, 2024
…llback-for-haystack

feat: Create Argilla `CallBack` for `haystack`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create ArgillaCallback for Haystack
2 participants