Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable Apply button if driver changed then options updated before applying driver switch #1712

Merged

Conversation

remutro
Copy link
Contributor

@remutro remutro commented Dec 6, 2024

If you choose to select a new driver without pressing the Apply button, and then go ahead and update related options for the currently loaded driver then the combo box will revert to the currently loaded driver but leave the Apply button enabled indicating the user has to do something when they do not. This changes this behavior so that if options are changed and the driver is reverted back to the current driver the Apply button will be disabled again.

@remutro remutro marked this pull request as draft December 6, 2024 17:25
@remutro remutro marked this pull request as ready for review December 6, 2024 17:55
@LukeUsher LukeUsher merged commit 4691971 into ares-emulator:master Dec 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants