n64: reenable isviewer even outside of homebrew mode #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISViewer is currently gated by the homebrew mode flag. It seems like this is not ideal for rom hackers because they would still need a way to log but homebrew mode is too verbose for them and hide the ISViewer messages in streams of actual problems in game code that they don't intend to fix. So restore ISViewer functionality without homebrew mode.
Dragorn421
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISViewer is currently gated by the homebrew mode flag. It seems like this is not ideal for rom hackers because they would still need a way to log but homebrew mode is too verbose for them and hide the ISViewer messages in streams of actual problems in game code that they don't intend to fix. So restore ISViewer functionality without homebrew mode.