gba: improve save type detection for homebrew #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commercial GBA games contain strings in the ROM that correspond to a save type (e.g. SRAM, flash memory, EEPROM), followed by 3 digits. These strings are used by ares to detect what save type to use. However, when running jsmolka's SRAM and flash memory save tests, ares does not detect a save type, since the programs lack the 3 digits at the end of the save type string. This PR ignores the trailing digits during save type detection, since it's likely that many other homebrew programs are affected by the same issue (GBATEK even advises developers to not add digits when including save type strings).