n64: improve PIF HLE emulation by reducing latency #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing PIF HLE emulation, we run the HLE state machine just once per frame. This is OK in general, but there can be a few situations where this can cause PIF to miss one command from CPU. For instance, a ROM might send the PIF boot termination command (0x8) and then shortly after issue a SI DMA to identify controllers. If the two happen within the same frame, our HLE emulation would miss the boot termination command.
This commit updates the HLE state machine also after each write to PIF RAM.