ColecoVision - Added "Super Action Controller" support #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for the "Super Action Controller". I an unsure how exactly the best setup for the controls when it comes to that binding thing. Unsure exacty how its ment to be layed out, but this works and works in the controller test roms. This is kinda a hack job with copied and modified code (controllers are nearly identical electronically to the original sock version just with two extra keys added). Also note the keys for this controller are typically listed from F1 to F4 renaming the L and R buttons... though that said cant find meeny first hand docs nameing those buttons on the oringal controller other than button 1 and button 2... so maybe they should be renamed in the emulator?.. idk, up to you lot. Let me know of any problems
|
Wait you cant press F3 and F4 at the same time and i completely forgot the roller existed on these controllers.... How can you unpull something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the "Super Action Controller".
I an unsure how exactly the best setup for the controls when it comes to that binding thing. Unsure exacty how its ment to be layed out, but this works and works in the controller test roms.
This is kinda a hack job with copied and modified code (controllers are nearly identical electronically to the original sock version just with two extra keys added).
Also note the keys for this controller are typically listed from F1 to F4 renaming the L and R buttons... though that said cant find meeny first hand docs nameing those buttons on the oringal controller other than button 1 and button 2... so maybe they should be renamed in the emulator?.. idk, up to you lot.
Let me know of any problems.