build: enable strict standards conformance with cl (msvc) #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the MSVC docs: "You can use the /permissive- compiler option to specify standards-conforming compiler behavior. This option disables permissive behaviors, and sets the /Zc compiler options for strict conformance." While generally a positive thing, this does make MSVC stricter than GCC/Clang in some cases. A couple of things popped out: - nall::multiFactorImage had a busted constructor. I fixed this and did some other cleanup while I was at it. - nall::string has an implicit conversion operator to const char*. This is honestly really ugly and creates ambiguity and allows for all kinds of surprising silent conversions. Unfortunately, fixing that (by making it explicit) will require touching hundreds of lines of code so I opted not to deal with it now. Instead I fixed the much smaller number of ambigous cases relating to string literals.
invertego
added a commit
to invertego/ares
that referenced
this pull request
Dec 13, 2023
…tor#1317) From the MSVC docs: "You can use the /permissive- compiler option to specify standards-conforming compiler behavior. This option disables permissive behaviors, and sets the /Zc compiler options for strict conformance." While generally a positive thing, this does make MSVC stricter than GCC/Clang in some cases. A couple of things popped out: - nall::multiFactorImage had a busted constructor. I fixed this and did some other cleanup while I was at it. - nall::string has an implicit conversion operator to const char*. This is honestly really ugly and creates ambiguity and allows for all kinds of surprising silent conversions. Unfortunately, fixing that (by making it explicit) will require touching hundreds of lines of code so I opted not to deal with it now. Instead I fixed the much smaller number of ambigous cases relating to string literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the MSVC docs: "You can use the /permissive- compiler option to specify standards-conforming compiler behavior. This option disables permissive behaviors, and sets the /Zc compiler options for strict conformance."
While generally a positive thing, this does make MSVC stricter than GCC/Clang in some cases. A couple of things popped out: