-
Notifications
You must be signed in to change notification settings - Fork 131
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gba: reset prefetch buffer on ROM accesses from CPU (#1377)
According to NanoBoyAdvance author fleroviux, the prefetch buffer should be reset on any ROM accesses from the CPU or DMA. This PR implements this behaviour for CPU ROM accesses. This allows ares to pass 1760/2020 of the timing tests in the mGBA test suite (up from 1608/2020). Allowing DMA ROM accesses to clear the prefetch buffer seems to worsen timings at the moment, possibly due to some other timing issues that also come into effect in these situations. I've left comments to make a note of the issue, so that resetting the prefetch buffer on ROM accesses from DMA can be implemented once it becomes beneficial to do so.
- Loading branch information
Showing
3 changed files
with
6 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters