Skip to content

Commit

Permalink
build: remove -fomit-frame-pointer (#1331)
Browse files Browse the repository at this point in the history
This option is usually enabled by default by GCC/Clang with -O1 and
above. This is not true on some targets like macOS/arm64, and there we
are better off deferring to the compiler anyway.

This became an issue because Xcode 15 shipped with a new linker that, at
least when LTO is enabled, appears to mess up metadata that is used to
unwind the stack during exception handling. Without a frame pointer to
fall back on, unwinding fails completely and causes ares to terminate.
  • Loading branch information
invertego authored Dec 6, 2023
1 parent e176d8b commit 1146c0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nall/GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ else ifeq ($(build),optimized)
ifeq ($(cl),true)
flags += -O2
else
flags += -O3 -fomit-frame-pointer
flags += -O3
endif
flags += -DBUILD_OPTIMIZED
else
Expand Down

0 comments on commit 1146c0d

Please sign in to comment.