Fixes to reduce excessive number of queries #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In many of our projects, we use settings quite extensively. On one of the pages, the number of queries reached 84 (this includes application logic). With the changes from this PR, we have reduced this to 17.
The change in
SettingsGroup'caches' the AppSettings model, asgetSettingsModel()is called in quite a few placed.The change in
TwillAppSettingsloads the entire blocks relation into the model instead of creating a new query each time. Even when you have multiple sections within the same AppSettings, theblockswill only be loaded once.The change in the
AppSettingmodel is there in case someone wants to hook into thesavedevent of the AppSetting and expects to retrieve the new values. The same logic is in the test because technically the settings are updated in the same 'request' while the blocks were already loaded before the POST request.Related Issues
This aims to solve the same problem as #2304